Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pullreq/commandline2 #416

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Salz
Copy link
Contributor

@Salz Salz commented Jan 13, 2021

Linux/GTK: fix command line parsing

Specifying any options on the command line besides the ROM dump aborts with "Unknown option <--option-name>". Also a lot of parsed file names were stored in private members of CommandLine and never exposed to the main application.

Specifying any options on the command line besides the ROM dump aborts
with "Unknown option <--option-name>". This happened after starting the
GTK application, which wants to parse the command line again.

Install an empty command-line signal handler into the GTK application,
since options are already parsed by CommandLine::parse().
Setting .nds_filename was alredy done by CommandLine::parse(), too, so
the signal handler for open can be removed.
A lot of file names were stored in private char * pointers in the
CommandLine class when the main application was looking at public
std::string members. Remove the private mempers and store all file names
in the public std::string members.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant