Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#364 Dark Mode #366

Merged
merged 32 commits into from
Oct 19, 2023
Merged

#364 Dark Mode #366

merged 32 commits into from
Oct 19, 2023

Conversation

SponsoredByPuma
Copy link
Contributor

implemented a Dark Mode for Diveni

@SponsoredByPuma SponsoredByPuma added javascript Pull requests that update Javascript code frontend feature request labels Jul 24, 2023
@SponsoredByPuma SponsoredByPuma self-assigned this Jul 24, 2023
@SponsoredByPuma SponsoredByPuma linked an issue Jul 24, 2023 that may be closed by this pull request
Dark Mode #364
Closed
@SponsoredByPuma
Copy link
Contributor Author

Everything should be styleable right now. Now we just need to find the correct colours for the elements.

@SponsoredByPuma SponsoredByPuma marked this pull request as ready for review July 26, 2023 10:30
Till Wanner and others added 16 commits August 1, 2023 09:35
@KzuDemEvin KzuDemEvin marked this pull request as draft August 8, 2023 08:57
@SponsoredByPuma SponsoredByPuma marked this pull request as ready for review August 17, 2023 10:11
@SponsoredByPuma SponsoredByPuma mentioned this pull request Sep 27, 2023
Closed
stritti
stritti requested changes Sep 28, 2023
View reviewed changes
Copy link
Member

@stritti stritti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid styles and use class definitions instead.

There are also some lint-issues.

frontend/src/components/navigation/TopNavigationBar.vue Outdated Show resolved Hide resolved
frontend/src/components/CardSetComponent.vue Outdated Show resolved Hide resolved
frontend/src/components/MemberVoteCard.vue Outdated Show resolved Hide resolved
frontend/src/components/RoundedAvatar.vue Outdated Show resolved Hide resolved
frontend/src/components/SignInWithJiraServerButtonComponent.vue Outdated Show resolved Hide resolved
frontend/src/views/AboutPage.vue Outdated Show resolved Hide resolved
frontend/src/views/AboutPage.vue Outdated Show resolved Hide resolved
frontend/src/views/AboutPage.vue Outdated Show resolved Hide resolved
frontend/src/views/AboutPage.vue Outdated Show resolved Hide resolved
frontend/src/views/AboutPage.vue Outdated Show resolved Hide resolved
@stritti
Copy link
Member

stritti commented Oct 6, 2023

I think this could be merged. Probably upcoming changes could be done in separate issues.

@Dan1elBox
Copy link
Collaborator

It looks really good👍
The only issue I've noticed is the incorrect scrollbar coloring for story titles in Firefox, as shown in the picture, but you're already aware of that:
Coloring Scrollbar


Also is it intentional that on the session page, the list of issues, as well as the title and description, are all arranged one below the other?

Old session page alignment:
Old-Session

New session page alignment:
New-Session

@SponsoredByPuma SponsoredByPuma merged commit a188839 into main Oct 19, 2023
2 checks passed
@SponsoredByPuma SponsoredByPuma deleted the 364-dark-mode branch October 19, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stritti stritti stritti approved these changes

@KzuDemEvin KzuDemEvin Awaiting requested review from KzuDemEvin

@Dan1elBox Dan1elBox Awaiting requested review from Dan1elBox

Assignees

@SponsoredByPuma SponsoredByPuma

Labels
feature request frontend javascript Pull requests that update Javascript code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dark Mode
3 participants
@SponsoredByPuma @stritti @Dan1elBox