Refactor FixCasingAfterTitles to use class fields. #8669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracted the arrays `_titles` and `_notChangeWords` as readonly class fields to reduce redundancy and improve readability. Adjusted the associated logic to reference these fields instead of creating new arrays within the method. Signed-off-by: Ivandro Jao <Ivandrofly@gmail.com>
ivandrofly
commented
Jul 25, 2024
| @@ -159,24 +159,25 @@ private static string FixEnglishAloneILowerToUpper(string input) | |||
| return text; | |||
| } | |||
|
|
|||
| private readonly string[] _titles = { "Mrs.", "Miss.", "Mr.", "Ms.", "Dr." }; | |||
| private readonly string[] _notChangeWords = { "does", "has", "will", "is", "and", "for", "but", "or", "of" }; | |||
There was a problem hiding this comment.
Moved outside 'cause FixCasingAfterTitles is being callow inside a foreach-paragraph
which would alloc n*_titles + n*_notChangeWords
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted the arrays
_titlesand_notChangeWordsas readonly class fields to reduce redundancy and improve readability. Adjusted the associated logic to reference these fields instead of creating new arrays within the method.