forked from cdyk/rvmparser
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge in Head #4
Open
Rjvs
wants to merge
75
commits into
rapidjson-writer
Choose a base branch
from
master
base: rapidjson-writer
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed sphere geometry kind
…checks on current offset versus expected offset.
- Fixes issue pointed out by @minorai that the length field in the chunk header actually is the offset of the next chunk. - Adds check to verify that offset of next chunk is where it is expected. - Renamed some variables in ParserRVM to make the code more readable.
…in an extras field in the header
Export data as GLTF (GLB)
Added note about upgrading solution
Handle the case that the normal is NaN before normalization
Rjvs
added
bug
Something isn't working
technical debt
Make life easier for ourselves
labels
Jul 30, 2021
…can be handled with the same base code
…at encodes translucency
Partial support exporting data as rev file
Handle obstruction and insulation chunks using feedback from @ddcsjtu
# Conflicts: # msvc15/rvmparser.vcxproj # src/ParserRVM.cpp # src/main.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key changes from upstream: