Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build issues on Windows #5

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix build issues on Windows #5

wants to merge 3 commits into from

Commits on May 15, 2024

  1. fix build issues on Windows 

    - call cmake build steps so it is compatible with Windows and linux
- protect unix specific includes so they are not include in Windows
- avoid to link to unix lib in Windows
    @mhandb
    mhandb committed May 15, 2024
    Configuration menu
    Copy the full SHA
    f0de764 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. use stdcall calling convention even in x86 

    It allows the project to build for x86 target without changing the glad source code.
Indeed, in windows the default calling convention for x86 is cdecl.
And the glad source code expect some functions to use the stdcall calling convention.
    @mhandb
    mhandb committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    cc7903d View commit details
    Browse the repository at this point in the history

  2. revert use of a CMake workaround for 32bit build 

    TODO: fix the code to support 32bit builds
    @mhandb
    mhandb committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    e3276d3 View commit details
    Browse the repository at this point in the history