Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source ParsedQuery key/value pairs from QueryString + Form instead of all Request.Params #123

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tms
Copy link
Contributor

@tms tms commented Jan 8, 2023

I unfortunately don't have Data Explorer set up to verify these changes at the immediate moment, but as uncovered by this Meta post, we seed the variable substitution for ParsedQuery with the key/value pairs from Request.Params.

Request.Params "gets a combined collection of QueryString, Form, Cookies, and ServerVariables items", which inadvertently makes it possible to dump cookie or IIS server variable values (in the case of the Meta post, it's a conflict with the server variable "url"). Not ideal!

This change puts the user supplied parameters we care about into a single property that we can then pass into ParsedQuery in various places. It's likely also possible to just use Request.QueryString or Request.Form as appropriate, but I felt less confident in that change since the current behaviour would mask if we had a route that allowed you to use both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant