🐛 Enable usePolling on Windows to fix file-lock
#1523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misode
requested changes
Jul 15, 2024
|
I tried this PR on the Gamemode 4 project and looking at the logs, after 10 minutes of waiting the file watcher still wasn't ready. There were 32K files in my workspace, so that's not the average project, but if we add this it should definitely be opt-in |
MulverineX
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There hasn't been a noticeable performance drop in my (fairly large) project so I think this solution is more than good enough 🤷
(if anyone wants to do some performance checks on this in voice chat with me I'd be more than happy to. not entirely sure what to check other than speed at which a file is re-parsed upon changing)
Preview