🐛 Fix poor merge behavior of Config
+ overrides
#1519
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while working on #1517, i realized that if you specified an empty object for
feature: {}
, it would effectively delete all otherenv.feature
config properties.example:
this is undesired behavior for a config system -- users should not need to specify every adjacent property to override a nested config setting
turns out there was an old
FIXME
to do this anyway. we have acore.merge
method that behaves the way we want so I just hooked into it in this PR