Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Re-check client managed files after ready #1511

Merged
merged 1 commit into from
Aug 1, 2024
Merged

🐛 Re-check client managed files after ready #1511

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions packages/core/src/service/Project.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,12 +377,17 @@ export class Project implements ExternalEventEmitter {
this.tryClearingCache(uri)
}).on('ready', () => {
this.#isReady = true
// // Recheck client managed files after the READY process, as they may have incomplete results and are user-facing.
// const promises: Promise<unknown>[] = []
// for (const { doc, node } of this.#clientManagedDocAndNodes.values()) {
// promises.push(this.check(doc, node))
// }
// Promise.all(promises).catch(e => this.logger.error('[Project#ready] Error occurred when rechecking client managed files after READY', e))
// Recheck client managed files after the READY process, as they may have incomplete results and are user-facing.
const promises: Promise<unknown>[] = []
for (const { doc, node } of this.#clientManagedDocAndNodes.values()) {
promises.push(this.check(doc, node))
}
Promise.all(promises).catch(e =>
this.logger.error(
'[Project#ready] Error occurred when rechecking client managed files after READY',
e,
)
)
})
}

Expand Down
Loading