Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nopol works on Java 11 #214

Merged
merged 40 commits into from
Jan 24, 2022
Merged

Conversation

andre15silva
Copy link
Contributor

@andre15silva andre15silva commented Mar 21, 2021

fix #211

Testing in CI env. Compilation is working, tests are not (locally).

@andre15silva
Copy link
Contributor Author

andre15silva commented Mar 22, 2021

There was a bug there due to a change in the API. URLClassLoader is no longer a super class for the system ClassLoaders.

I found a workaround to do this (See https://cgjennings.ca/articles/java-9-dynamic-jar-loading/)

Dynamoth should now be working. Its tested are all green.

There is a bug, however, with GZoltar. Haven't found a solution for that.

TODO:

  • load javaagent in normal execution
  • fix GZoltar

@monperrus monperrus mentioned this pull request Mar 25, 2021
@monperrus
Copy link
Contributor

monperrus commented Sep 8, 2021

Waiting for #220 (FL based on Flacoco) which is a blocker for the one

@monperrus
Copy link
Contributor

now that we have Flacoco, are we ready to support Java 11?

Signed-off-by: André Silva <andre15andre@hotmail.com>
Signed-off-by: André Silva <andre15andre@hotmail.com>
Signed-off-by: André Silva <andre15andre@hotmail.com>
@monperrus monperrus changed the title WIP: Bump to Java 11 Nopol works on Java 11 Jan 22, 2022
@monperrus
Copy link
Contributor

Spent some long hours here. It's now working.

Notes:

  • in Java 11, tools.jar has been renamed and even has a new format (JMOD), it's now jdk.jdi.jmod
  • some TSE and Defects4J bugs (in particular Lang) requires java source code version 3 or 4. While 3 or 4 was still supported in a JVM 8, they have been dropped in 11. Consequently, we lose them all as test case. Yet, I ported 4 of them manually (Lang44, Lang51, Lang53, Lang58), and pushed them to defects4j-repair, eg https://github.com/Spirals-Team/defects4j-repair/tree/Lang58-Java6
  • the trick with the classloader of cgjennings was nice, eventually I found a way to remove the need for that
  • porting nopol-ui-intellij was tedious because of the stacked and interleaved problems of upgrading the JVM version, the Gradle version, the IntelliJ version

I'd say it's done,, and this opens the door for getting https://ci.inria.fr/sos/job/Nopol/ green again

@monperrus monperrus marked this pull request as ready for review January 23, 2022 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Java 11
2 participants