Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uascent WIFI Smart Switch Fingerprint Add #1683

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gobau
Copy link

@gobau gobau commented Oct 13, 2024

and child_profile if code change

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Uascent WIFI Smart Switch Fingerprint Add

제가 구매한 중선선없는Matter WIFI 스마트 터치식 스위치가 fingerprint가 없어서 이렇게 추가하여 PullRequest를 보냅니다.

단순하게 fingerprint.yml 만 수정하였고, 작동이 잘됩니다.

반영하여, 다른사람들도 제가 구매한 제품 이용시 편해졌으면 좋겠습니다.

구매한 제품 정보 https://ko.aliexpress.com/item/1005007028700471.html?spm=a2g0o.order_list.order_list_main.29.2450140f5WHw8V&gatewayAdapt=glo2kor

The Matter WIFI smart touch switch I bought without the middle wire doesn't have a fingerprint, so I'm sending you a PullRequest by adding it like this.

I simply modified the fingerprint.yml, and it worked well.

Reflecting this, I hope other people will also be comfortable using the products I purchased.

Purchased Product Information https://ko.aliexpress.com/item/1005007028700471.html?spm=a2g0o.order_list.order_list_main.29.2450140f5WHw8V&gatewayAdapt=glo2kor

Summary of Completed Tests

and child_profile if code change
@CLAassistant
Copy link

CLAassistant commented Oct 13, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ gobau
❌ k01057200432
You have signed the CLA already but the status is still pending? Let us recheck it.

@lelandblue
Copy link
Contributor

Hello @gobau Thank you for your effort. At this time we only accept new fingerprint additions for devices that intend to go through the WWST process. For more information please check out our README or developers.smartthings.com

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants