Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review Failing Checks Draft #50

Draft
wants to merge 10 commits into
base: dev
Choose a base branch
from
Draft

Review Failing Checks Draft #50

wants to merge 10 commits into from

Conversation

HawkerTheGreat
Copy link
Contributor

Will fill in later, attempting to change code in order to pass the failing checks.

@HawkerTheGreat
Copy link
Contributor Author

Just a test, this fix might be beyond my knowledge of coding.

@HawkerTheGreat
Copy link
Contributor Author

Second test, checking the previous commits to find bad indentation errors. DO NOT MERGE.

@HawkerTheGreat HawkerTheGreat changed the title Appease checks with Runechat Review Failing Checks Draft Sep 19, 2021
Codingale
Codingale approved these changes Sep 19, 2021
View reviewed changes
Copy link
Collaborator

@Codingale Codingale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, but was this before the PR was merged for the Simplemobs fix? That for some reason is throwing runtimes still from what I can tell in the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Codingale Codingale Codingale approved these changes

Assignees
No one assigned
Labels
Do Not Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HawkerTheGreat @Codingale @Guidesu