Skip to content
This repository has been archived by the owner on Jul 19, 2021. It is now read-only.

Update Themekit version and themekit-node API #1058

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

JTimNolan
Copy link

What are you trying to accomplish with this PR?

fixes #1057 by updating themekit binary and themekit-node api calls to the latest version

Checklist

For contributors:

For maintainers:

  • [N/A] I have 🎩'd these changes.

@ghost ghost added the cla-needed label Sep 21, 2019
@@ -78,9 +69,9 @@ function _generateIgnoreFlags() {
* @return Promise
*/
async function deploy(cmd = '', files = []) {
if (!['upload', 'replace'].includes(cmd)) {
if (!['deploy', 'replace'].includes(cmd)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like replace doesn't exist anymore? And has been replaced by deploy. And that upload has been replaced by deploy --nodelete?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you're right. I'll update the the commands and documentation to reflect this when I get a chance

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slate-tools using themekit 0.6.12
2 participants