Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dropdown in booking page assets management #1370

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

vikashsprem
Copy link

@vikashsprem vikashsprem commented Oct 25, 2024

Closes #1368
/claim #1368

Screen.Recording.2024-10-25.at.8.01.37.AM.mp4

@vikashsprem
Copy link
Author

@carlosvirreira Please review.

Copy link
Contributor

@DonKoko DonKoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great first PR. I have added some feedback with some changes needed to make it more fitting to our normal coding style in shelf.

app/components/booking/booking-assets-column.tsx Outdated Show resolved Hide resolved
app/components/booking/booking-assets-column.tsx Outdated Show resolved Hide resolved
app/components/booking/booking-assets-column.tsx Outdated Show resolved Hide resolved
app/components/booking/booking-assets-column.tsx Outdated Show resolved Hide resolved
app/components/booking/booking-assets-column.tsx Outdated Show resolved Hide resolved
@vikashsprem
Copy link
Author

@DonKoko I have made the requested changes plz review

Copy link
Contributor

@DonKoko DonKoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • When items are folded its strange they dont have a border between them:
Screenshot 2024-10-25 at 14 42 28 - [ ] Same when I hover an item. We need to address those cases to make the UI consistent Screenshot 2024-10-25 at 14 42 36 - [ ] Hover of arrow should be `text-gray-500`. Now it becomes orange which is wrong. Screenshot 2024-10-25 at 14 43 16 - [ ] Lets make the default state to be "open"

app/components/booking/booking-assets-column.tsx Outdated Show resolved Hide resolved
@vikashsprem
Copy link
Author

Hey @DonKoko, Made the suggested changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request]: Accordion support for visualising kits on booking view
2 participants