Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up patches to _LINKSTO #245

Merged
merged 2 commits into from
Oct 26, 2024

Conversation

alistair3149
Copy link
Contributor

@alistair3149 alistair3149 commented Oct 25, 2024

This PR is made in reference to: #216

  • Add documentation for _LINKSTO
  • Address various issues raised by phpcs

@alistair3149 alistair3149 mentioned this pull request Oct 25, 2024
2 tasks
@alistair3149 alistair3149 changed the title doc: add _LINKSTO to configuration [WIP] Follow up patches to _LINKSTO Oct 25, 2024
@alistair3149
Copy link
Contributor Author

Marking as WIP to address other issues raised by CI

@alistair3149 alistair3149 changed the title [WIP] Follow up patches to _LINKSTO Follow up patches to _LINKSTO Oct 25, 2024
@alistair3149
Copy link
Contributor Author

@jaideraf ready for review

Copy link

codecov bot commented Oct 26, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.78%. Comparing base (80466ac) to head (d3e3400).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...rc/PropertyAnnotators/LinksToPropertyAnnotator.php 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #245      +/-   ##
============================================
- Coverage     88.01%   87.78%   -0.24%     
- Complexity      362      373      +11     
============================================
  Files            35       36       +1     
  Lines          1018     1203     +185     
============================================
+ Hits            896     1056     +160     
- Misses          122      147      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JeroenDeDauw JeroenDeDauw merged commit 636c399 into SemanticMediaWiki:master Oct 26, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants