Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OAB-22] play sound on win roll #23

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

polakowski
Copy link
Contributor

This closes #22

Overview

Play fanfare sound after a win roll.

Copy link
Member

@Skysplit Skysplit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not running mpg321 command using child_process#spawn or child_process#fork?

https://nodejs.org/dist/latest-v10.x/docs/api/child_process.html#child_process_child_process_spawn_command_args_options

@polakowski
Copy link
Contributor Author

@Skysplit I just wanted to use "dedicated" library to run Python files. I googled "node run python" and this is what I found. Is there something wrong with the python-shell? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

play sound on win roll
4 participants