[java] Fix SpotBugs bugs in manager #14608
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
Description
As described in this comment, SpotBugs found some additional bugs in the code.
In this PR I fix part of the found problems.
SpotBugs errors:
Solutions:
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE
to ignore potential null value from thebinary.getParent()
call - SpotBugs exclusion forgetParent
call is common, for example fororg.openqa.selenium.firefox.FirefoxBinary
path.toFile().mkdirs()
withFiles.createDirectories(path)
- use ofFiles.createDirectories
is common in the code base, so it is consistentMotivation and Context
Fixing the actual problems is necessary before enabling full SpotBugs analysis, in order to not break the build.
Types of changes
Checklist
PR Type
Bug fix
Description
SeleniumManager
by replacingmkdirs()
withFiles.createDirectories()
.SeleniumManagerOutput.fromJson
to handle unexpected JSON values.SeleniumManager
.Changes walkthrough 📝
SeleniumManager.java
Improve directory creation error handling in SeleniumManager
java/src/org/openqa/selenium/manager/SeleniumManager.java
mkdirs()
withFiles.createDirectories()
for better errorhandling.
SeleniumManagerOutput.java
Add default case to switch statement in fromJson
java/src/org/openqa/selenium/manager/SeleniumManagerOutput.java
fromJson
.spotbugs-excludes.xml
Update SpotBugs exclusions for SeleniumManager
java/spotbugs-excludes.xml
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE
.