Update lock files, pin Cartopy!=0.23 #6171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
benchmark_this
⏱️ Performance Benchmark Report: 642c3e0Performance shiftsFull benchmark resultsGenerated by GHA run |
This was referenced Oct 10, 2024
trexfeathers
added a commit
to trexfeathers/iris-test-data
that referenced
this pull request
Oct 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6171 +/- ##
==========================================
+ Coverage 89.81% 89.83% +0.02%
==========================================
Files 88 88
Lines 23174 23167 -7
Branches 5045 4310 -735
==========================================
- Hits 20814 20813 -1
Misses 1623 1623
+ Partials 737 731 -6 ☔ View full report in Codecov by Sentry. |
|
As far as I can tell: ALL collapse benchmarks have become slower. Some have not triggered the threshold. This appears to be a function of how long the benchmark takes - longer benchmarks have changed less, suggesting the regression is an overhead of some sort (the regression itself does not scale). It's hard to tell but I believe the weighted collapse benchmarks ( The aggregated_by benchmarks appear unchanged. There aren't many changes in the lock files, and I struggle to see how any of the changes could affect collapsing but not aggregating - they both use the same operation under the hood. |
|
SciTools/cartopy#2414 made a minor change that had two effects for Iris:
Did the due diligence on the image tests that had failed and confirmed that there was no evidence of something malfunctioning, just a minor visual change going forward. |
ESadek-MO
pushed a commit
to SciTools/iris-test-data
that referenced
this pull request
Oct 11, 2024
⏱️ Performance Benchmark Report: c9a96caPerformance shiftsFull benchmark resultsGenerated by GHA run |
I was hoping to replicate locally, then I could do some scalability testing, but my local results suffer from too much variance to identify these regressions (which itself demonstrates how small they are). Regardless: the only action we could reasonably take would be to warn users of the regression (we can't fix it if it's in a dependency), but I propose that a regression this small, and one that seemingly does not scale, is not worth warning users about. (Happy for this to be merged before the latest benchmark run finishes). |
ESadek-MO
approved these changes
Oct 11, 2024
⏱️ Performance Benchmark Report: bece7f7Performance shiftsFull benchmark resultsGenerated by GHA run |
⏱️ Performance Benchmark Report: e4ee4f5Performance shiftsFull benchmark resultsGenerated by GHA run |
⏱️ Performance Benchmark Report: 272584fPerformance shiftsFull benchmark resultsGenerated by GHA run |
⏱️ Performance Benchmark Report: fa30c42Performance shiftsFull benchmark resultsGenerated by GHA run |
ukmo-ccbunney
added a commit
to ukmo-ccbunney/iris
that referenced
this pull request
Oct 15, 2024
* upstream/main: Make Iris backwards compatible with Cartopy (SciTools#6172) Updated environment lockfiles (SciTools#6173) Bump scitools/workflows from 2024.09.9 to 2024.10.0 (SciTools#6170) Update lock files, pin Cartopy!=0.23 (SciTools#6171)
stephenworsley
added a commit
to stephenworsley/iris
that referenced
this pull request
Oct 22, 2024
* main: [pre-commit.ci] pre-commit autoupdate (SciTools#6175) Updated environment lockfiles (SciTools#6183) Update to `cell_method` parsing (SciTools#6083) Bump scitools/workflows from 2024.10.0 to 2024.10.1 (SciTools#6179) `colorbar` keyword for iris.quickplot routines (SciTools#6169) Make Iris backwards compatible with Cartopy (SciTools#6172) Updated environment lockfiles (SciTools#6173) Bump scitools/workflows from 2024.09.9 to 2024.10.0 (SciTools#6170) Update lock files, pin Cartopy!=0.23 (SciTools#6171)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Includes the removal of the
GeoAxesmonkey patch - closes #5977.Forced to do this now since we haven't yet got Read the Docs locked down (SciTools/workflows#38), so that's already getting Cartopy v0.24 and therefore failing our CI.
Consult Iris pull request check list
Add any of the below labels to trigger actions on this PR: