-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include ancillary variables and cell_measures during intersect #5804
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5804 +/- ##
==========================================
- Coverage 89.77% 89.77% -0.01%
==========================================
Files 88 88
Lines 23026 23037 +11
Branches 5036 5038 +2
==========================================
+ Hits 20672 20681 +9
- Misses 1623 1624 +1
- Partials 731 732 +1 ☔ View full report in Codecov by Sentry. |
Two notes on last commit:
|
Hi @ESadek-MO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small suggestions which I think make it simpler
(though you may disagree !)
I did also wonder if we should check that the newly constructed cell_measures / ancillaries remain lazy. But on second thoughts I don't think it's really needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks fine now to me
🚀 Pull Request
Closes #5413.
To do: