Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update jumps for Catalyst 14 #132

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

isaacsas
Copy link
Member

Note this is breaking and will likely break one or more SciMLBenchmarks that use this code.

@isaacsas
Copy link
Member Author

isaacsas commented Jul 22, 2024

Torkel and I have discussed factoring out some of the many networks now defined in the Catalyst docs to a separate library. It might make sense to drop these and switch to that at some point for things like SciMLBenchmarks.

@@ -1,6 +1,6 @@
name = "JumpProblemLibrary"
uuid = "faf0f6d7-8cee-47cb-b27c-1eb80cef534e"
version = "0.1.4"
version = "0.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version = "0.2"
version = "1.0.0"

let's not keep everything 0-based forever 😅

@ChrisRackauckas
Copy link
Member

That's fine, all benchmarks are semver

@isaacsas isaacsas merged commit 878c460 into SciML:master Jul 22, 2024
10 checks passed
@isaacsas isaacsas deleted the update_jumpproc_for_catalyst14 branch July 22, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants