Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix (cyclic dependencies): remove cyclic dependencies #1951

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix (cyclic dependencies): remove cyclic dependencies #1951

wants to merge 2 commits into from

Conversation

ChristianBusshoff
Copy link
Contributor

  • moved @sit-onyx/storybook-utils and @sit-onyx/eslint-plugin from root to the repos where there are directly used
  • added an preinstall script to check for Cyclic dependencies

@ChristianBusshoff ChristianBusshoff requested a review from a team as a code owner October 11, 2024 06:53
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 11, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: a602944

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ChristianBusshoff ChristianBusshoff changed the title fix (cyclic dependencies): remove cyclic dependencies #1713 fix (cyclic dependencies): remove cyclic dependencies Oct 11, 2024
JoCa96
JoCa96 requested changes Oct 14, 2024
View reviewed changes
package.json
@@ -16,7 +16,7 @@
"publint:all": "pnpm -r --parallel --aggregate-output exec publint",
"prepare": "simple-git-hooks",
"gh:show-report": "./scripts/show-last-test-report.sh",
"preinstall": "npx only-allow pnpm"
"preinstall": "npx only-allow pnpm && pnpm list --depth=-1 --long | grep cycle && echo 'Cyclic dependency detected!' && exit 1 || echo 'No cyclic dependencies'"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pnpm list --depth=-1 --long doesn't output anything for me, can you check the script please?

@JoCa96 JoCa96 self-assigned this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoCa96 JoCa96 JoCa96 requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@JoCa96 JoCa96

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChristianBusshoff @JoCa96