Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(publish): disable CGO #275

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Conversation

EtienneM
Copy link
Member

@EtienneM EtienneM commented Oct 14, 2024

I tested this on my fork: https://github.com/EtienneM/link/releases/tag/v2.0.8

Then I downloaded both the v2.0.6 and v2.0.8 in /tmp of one of our database hosting servers. v2.0.8 seems to have fixed the issue.

v2.0.6:

[osc-st-fr1] root@ip-10-0-0-242 (node) /tmp$ wget https://github.com/Scalingo/link/releases/download/v2.0.6/link-v2.0.6-linux-amd64.tar.gz
[osc-st-fr1] root@ip-10-0-0-242 (node) /tmp$ tar xvzf ./link-v2.0.6-linux-amd64.tar.gz 
[osc-st-fr1] root@ip-10-0-0-242 (node) /tmp$ cd link-v2.0.6-linux-amd64/
[osc-st-fr1] root@ip-10-0-0-242 (node) /tmp/link-v2.0.6-linux-amd64$ ./link --help
./link: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found (required by ./link)
./link: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by ./link)

v2.0.8:

[osc-st-fr1] root@ip-10-0-0-242 (node) /tmp$ wget https://github.com/EtienneM/link/releases/download/v2.0.8/link-v2.0.8-linux-amd64.tar.gz                                                                                                                    
[osc-st-fr1] root@ip-10-0-0-242 (node) /tmp$ tar xvzf link-v2.0.8-linux-amd64.tar.gz 
[osc-st-fr1] root@ip-10-0-0-242 (node) /tmp$ cd link-v2.0.8-linux-amd64/
[osc-st-fr1] root@ip-10-0-0-242 (node) /tmp/link-v2.0.8-linux-amd64$ ./link --help
{"level":"warn","ts":"2024-10-14T13:57:51.712528Z","logger":"etcd-client","caller":"v3/retry_interceptor.go:63","msg":"retrying of unary invoker failed","target":"etcd-endpoints://0xc00027c780/","attempt":0,"error":"rpc error: code = DeadlineExceeded des
c = latest balancer error: last connection error: connection error: desc = \"transport: Error while dialing: dial tcp: missing address\""}
panic: fail to get current host to check if it needs data migration from v0 to v1: fail to get current host: fail to get host from etcd: context deadline exceeded

goroutine 1 [running]:
main.main()
        /home/runner/work/link/link/main.go:52 +0x1e31

Hence I think that it fixes the issue.

Related to https://github.com/Scalingo/appsdeck-kitchen/issues/2313

@EtienneM EtienneM self-assigned this Oct 14, 2024
@EtienneM EtienneM marked this pull request as ready for review October 14, 2024 14:05
@EtienneM EtienneM force-pushed the fix/kitchen/2313/link_disable_cgo branch from c53fb2f to 78d4f98 Compare October 14, 2024 14:05
Copy link
Member

@brandon-welsch brandon-welsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EtienneM EtienneM merged commit 7b071bd into master Oct 14, 2024
4 checks passed
@EtienneM EtienneM deleted the fix/kitchen/2313/link_disable_cgo branch October 14, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants