Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README and move start.sh script (and rename) #263

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

leo-scalingo
Copy link
Contributor

No description provided.

@leo-scalingo leo-scalingo self-assigned this Jun 21, 2024
Copy link
Member

@EtienneM EtienneM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion otherwise LGTM :)

@@ -121,21 +121,31 @@ This is the equivalent of:
ip addr del MY_IP dev MY_INTERFACE
```

## Dev environment
## Development environment
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: I like this kind of attention to details 🤩

```
for idx in 10 11 12 ; do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: maybe explicitly mention that this code block is bash to make sure it's correctly colored?

README.md Outdated Show resolved Hide resolved
@leo-scalingo leo-scalingo merged commit 88db08c into master Jun 21, 2024
3 checks passed
@leo-scalingo leo-scalingo deleted the dev/readme-setup branch June 21, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants