Common Log (In Progress) #6338

NayanaNagaraj23 · 2024-08-13T13:04:54Z

Make changes in Debug log statements to reduce the binary size

os/audio/audio.c

neel-samsung · 2024-08-16T00:50:49Z

Do we need these commits to merge into samsung/TizenRT:master directly? Although some of the commits don't have proper commit message and also description.

os/binfmt/binfmt_exec.c

os/include/tinyara/common_logs/common_logs.h

sunghan-chang · 2024-08-16T09:44:07Z

os/include/tinyara/common_logs/common_logs.h

+        "Potential memory leak :",	//CMN_LOG_MEM_LEAK,
+        "Buffer overflow detected :",	//CMN_LOG_BUFFER_OVERFLOW,


Oops, is it possible to check in code?

sunghan-chang · 2024-08-16T09:44:33Z

os/include/tinyara/common_logs/common_logs.h

+static const char* clog_message_str[CMN_LOG_MSG_MAX] =
+{
+	/* Memory Operations */
+        "Memory allocation failed :",	//CMN_LOG_ALLOC_FAIL,


Why all has : at the end? Every message has additional message after this?

Yes, we have messages at some places.

os/include/tinyara/common_logs/common_logs.h

os/audio/audio.c

os/binfmt/binfmt_exec.c

os/binfmt/binfmt_exit.c

os/binfmt/binfmt_initialize.c

os/binfmt/binfmt_loadbinary.c

os/binfmt/binfmt_unloadmodule.c

neel-samsung

Please check the conflicts and rebase the PR accordingly.

os/audio/audio.c

os/include/tinyara/common_logs/common_logs.h

os/pm/pm_metrics.c

r-prabu

Commit description should have detailed information about the changes & why we did it.

kishore-sn · 2024-09-13T07:48:35Z

os/include/tinyara/common_logs/common_logs.h

+		"End of",			//CMN_LOG_END,
+		"Invalid data in",  //CMN_LOG_INVALID_DATA,
+		"Valid data in :"   //CMN_LOG_VALID_DATA,
+		"Not supported",       // CMN_LOG_NOT_SUPPORTED


Fix indentation of all the above lines.

kishore-sn · 2024-09-13T07:49:12Z

os/include/tinyara/common_logs/common_logs.h

+static const char* clog_message_str[CMN_LOG_MSG_MAX] =
+{
+	/* Memory Operations */
+        "Memory allocation failure",	//CMN_LOG_ALLOC_FAIL,


Change failure to failed in all log msgs.

kishore-sn · 2024-09-13T07:50:23Z

os/include/tinyara/common_logs/common_logs.h

+
+	/* Network Operations */
+        "Connection Timeout",		//CMN_LOG_CON_TIMEOUT,
+        "Connection Refuse",		//CMN_LOG_CON_REFUSED,


Refuse -> refused

kishore-sn · 2024-09-13T07:51:34Z

os/include/tinyara/common_logs/common_logs.h

+        "IOCTL call failure", 	//CMN_LOG_FILE_IOCTL_ERROR,
+
+	/* Network Operations */
+        "Connection Timeout",		//CMN_LOG_CON_TIMEOUT,


Why using capital letter for all words in some log msgs? Pls make it same as other msgs. Use capital letter only for first word.

kishore-sn · 2024-09-13T08:01:20Z

os/drivers/video/video.c

@@ -1300,7 +1301,7 @@ FAR void *video_register(const char *devpath, FAR struct video_lowerhalf_s *dev)

 	priv = (FAR video_upperhalf_t *)kmm_malloc(sizeof(video_upperhalf_t));
 	if (!priv) {
-		videodbg("Failed to allocate instance\n");
+		videodbg("%s instance\n", clog_message_str[CMN_LOG_ALLOC_FAIL]);


%s for instance

kishore-sn · 2024-09-13T08:04:08Z

os/drivers/bluetooth/bt_null/bt_null.c

@@ -360,7 +361,7 @@ static int btnull_send(FAR const struct bt_driver_s *dev, FAR struct bt_buf_s *b

 		outbuf = bt_buf_alloc(BT_EVT, NULL, 0);
 		if (outbuf == NULL) {
-			ndbg("ERROR: Failed to allocate buffer\n");
+			ndbg("%s: bt_buf_alloc\n", clog_message_str[CMN_LOG_ALLOC_FAIL]);


Remove : bt_buf_alloc

kishore-sn · 2024-09-13T08:05:25Z

os/drivers/lcd/lcd_framebuffer.c

@@ -610,7 +611,7 @@ int up_fbinitialize(int display)

 	priv->fbmem  = (FAR uint8_t *)kmm_zalloc(priv->fblen);
 	if (priv->fbmem == NULL) {
-		gdbg("ERROR: Failed to allocate frame buffer memory\n");
+		gdbg("%s frame buffer\n", clog_message_str[CMN_LOG_ALLOC_FAIL]);


for frame buffer

kishore-sn · 2024-09-13T08:05:50Z

os/drivers/lcd/lcd_framebuffer.c

 	DEBUGASSERT((unsigned)display < UINT8_MAX);

 	/* Allocate the framebuffer state structure */

 	priv = (FAR struct lcdfb_dev_s *)kmm_zalloc(sizeof(struct lcdfb_dev_s));
 	if (priv == NULL) {
-		gdbg("ERROR: Failed to allocate state structure\n");
+		gdbg("%s state structure \n", clog_message_str[CMN_LOG_ALLOC_FAIL]);


for state structure

Make changes in the debug log messages with the common messages

ritesh55555 · 2024-10-21T06:48:53Z

os/include/tinyara/common_logs/common_logs.h

+	/* Memory Operations */
+	"Memory allocation failure",	//CMN_LOG_ALLOC_FAIL,
+	"Null pointer",				    //CMN_LOG_NULL_CHECK_FAIL,
+	"Potential memory leak",	    //CMN_LOG_MEM_LEAK,


comments can be indented

gSahitya-samsung reviewed Aug 14, 2024

View reviewed changes

os/audio/audio.c Outdated Show resolved Hide resolved

sunghan-chang reviewed Aug 16, 2024

View reviewed changes

NayanaNagaraj23 changed the title ~~Common Log~~ Common Log (In Progress) Aug 16, 2024

NayanaNagaraj23 force-pushed the temp_log_reduction branch 7 times, most recently from 1deca23 to 1e44cb1 Compare August 26, 2024 07:50

r-prabu requested changes Aug 29, 2024

View reviewed changes

NayanaNagaraj23 force-pushed the temp_log_reduction branch 3 times, most recently from 3ef52c8 to 76acdf3 Compare September 2, 2024 09:23

neel-samsung reviewed Sep 2, 2024

View reviewed changes

NayanaNagaraj23 force-pushed the temp_log_reduction branch 4 times, most recently from 5d1d435 to 334fb2b Compare September 5, 2024 05:27

Tirtha-Samsung reviewed Sep 5, 2024

View reviewed changes

os/audio/audio.c Show resolved Hide resolved

NayanaNagaraj23 force-pushed the temp_log_reduction branch 5 times, most recently from e8f0207 to c536712 Compare September 10, 2024 06:29

r-prabu reviewed Sep 11, 2024

View reviewed changes

os/include/tinyara/common_logs/common_logs.h Show resolved Hide resolved

r-prabu reviewed Sep 11, 2024

View reviewed changes

os/pm/pm_metrics.c Outdated Show resolved Hide resolved

r-prabu reviewed Sep 11, 2024

View reviewed changes

NayanaNagaraj23 force-pushed the temp_log_reduction branch from c536712 to 3c23105 Compare September 13, 2024 05:12

NayanaNagaraj23 force-pushed the temp_log_reduction branch from 3c23105 to d52a7f8 Compare September 13, 2024 05:22

kishore-sn reviewed Sep 13, 2024

View reviewed changes

os : Common log messages

f4fb92d

Make changes in the debug log messages with the common messages

NayanaNagaraj23 force-pushed the temp_log_reduction branch from d52a7f8 to f4fb92d Compare September 16, 2024 14:52

ritesh55555 reviewed Oct 21, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Common Log (In Progress) #6338

Common Log (In Progress) #6338

NayanaNagaraj23 commented Aug 13, 2024

neel-samsung commented Aug 16, 2024

sunghan-chang Aug 16, 2024

sunghan-chang Aug 16, 2024

NayanaNagaraj23 Sep 4, 2024

neel-samsung left a comment

r-prabu left a comment

kishore-sn Sep 13, 2024

kishore-sn Sep 13, 2024

kishore-sn Sep 13, 2024

kishore-sn Sep 13, 2024

kishore-sn Sep 13, 2024

kishore-sn Sep 13, 2024

kishore-sn Sep 13, 2024

kishore-sn Sep 13, 2024

ritesh55555 Oct 21, 2024

		"Potential memory leak :", //CMN_LOG_MEM_LEAK,
		"Buffer overflow detected :", //CMN_LOG_BUFFER_OVERFLOW,

Common Log (In Progress) #6338

Are you sure you want to change the base?

Common Log (In Progress) #6338

Conversation

NayanaNagaraj23 commented Aug 13, 2024

neel-samsung commented Aug 16, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

neel-samsung left a comment

Choose a reason for hiding this comment

r-prabu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment