[onert] Introduce capabilities to find operands which can share memory #14228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds capabilities to find operands linked which Tensors which can share memory buffers. It's applicable for ops like Reshape, Squeeze and ExpandsDims (where only shape is changed and data is not modified). ONE-DCO-1.0-Signed-off-by: Mateusz Bencer m.bencer@partner.samsung.com
zetwhite
reviewed
Oct 24, 2024
zetwhite
reviewed
Oct 24, 2024
Comment on lines
83
to
85
| { | ||
| shared_memory_operand_map[op.getOutputs().at(0)] = op.getInputs().at(0); | ||
| } |
There was a problem hiding this comment.
(optional) How about adding assertions here to check is_memory_sharing_allowed only captures single input - single output operation?
Before reading line 53 (ops_with_possible_memory_sharing), I didn't notice that it targets single input, single output operation.
Suggested change
| { | |
| shared_memory_operand_map[op.getOutputs().at(0)] = op.getInputs().at(0); | |
| } | |
| { | |
| assert(op.getInputs().size() == 1); | |
| assert(op.getOutputs().size() == 1); | |
| shared_memory_operand_map[op.getOutputs().at(0)] = op.getInputs().at(0); | |
| } |
There was a problem hiding this comment.
added (note that for Reshape/ExpandDims number of inputs is 2)
zetwhite
reviewed
Oct 24, 2024
Comment on lines
+33
to
+46
| for (auto [shared_ind, source_ind] : shared_memory_operand_map) | ||
| { | ||
| bool other_source_found = false; | ||
| auto it = std::end(shared_memory_operand_map); | ||
| while ((it = shared_memory_operand_map.find(source_ind)) != std::end(shared_memory_operand_map)) | ||
| { | ||
| source_ind = shared_memory_operand_map[source_ind]; | ||
| other_source_found = true; | ||
| } | ||
| if (other_source_found) | ||
| { | ||
| shared_memory_operand_map[shared_ind] = source_ind; | ||
| } | ||
| } |
There was a problem hiding this comment.
If shared_memory_operand_map = {{1, 2}, {2, 3}, {2, 4}} is given, is this works well..?
There was a problem hiding this comment.
As I understand 2 cannot indicate other operand two times. (I've made some experiments about this implementation here - https://godbolt.org/z/11KKr9xqY)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds capabilities to find operands linked which Tensors which can share memory buffers. It's applicable for ops like Reshape, Squeeze and ExpandsDims (where only shape is changed and data is not modified).
ONE-DCO-1.0-Signed-off-by: Mateusz Bencer m.bencer@partner.samsung.com
Draft: #14057