[onert-micro] Add svdf cmsis-nn #13719
Conversation
BalyshevArtem
force-pushed
the
svdf_cmsis_nn_onert_micro_draft
branch
from
d2bb71f
to
729f163
Compare
| nnas_include(OptionTools) | ||
|
|
||
| envoption(EXTERNAL_DOWNLOAD_SERVER "https://github.com") | ||
| envoption(CMSIS_NN_6_0_0_URL ${EXTERNAL_DOWNLOAD_SERVER}/ARM-software/CMSIS-NN/archive/refs/tags/v6.0.0.tar.gz) |
There was a problem hiding this comment.
@BalyshevArtem this PR does not work with CMSIS_NN 4.1 ? I am not sure which CMSIS_NN version in TizenRT.
There was a problem hiding this comment.
Hmmm, if it is critical, I can rewrite it with 4.1 cmsis-nn, but current implementation required 6.0. TFLITE-micro uses the 6.0 version. Rewrite using 4.0?
There was a problem hiding this comment.
It does not matter if it is compatible to TizenRT(but I do not know which version in TizenRT in use. It 'was' compatible to 4.1)
There was a problem hiding this comment.
FYI, internal TizenRT use the same file at https://github.com/Samsung/TizenRT/blob/master/external/include/cmsis_nn/arm_nnfunctions.h#L1675 for cmsis_nn. Seem like it is based on 4.1 instead of 6.0 (based on parameter numbers)
There was a problem hiding this comment.
Rewrite using 4.0?
Is it possible ? I do not know about SVDF. But CMSIS_NN 4.1 does not use kernel_sum at all in SVDF kernel.
There was a problem hiding this comment.
Is it possible ?
Yes :)
Okay, I will rewrite to 4.1 and close prs with cmsis-nn version updating
There was a problem hiding this comment.
Done, ready for review
This draft adds svdf cmsis-nn kernel. ONE-DCO-1.0-Signed-off-by: Artem Balyshev <a.balyshev@samsung.com
BalyshevArtem
force-pushed
the
svdf_cmsis_nn_onert_micro_draft
branch
from
729f163
to
c434966
Compare
BalyshevArtem
changed the title
BalyshevArtem
added
the
PR/ready for review
This pr adds svdf cmsis-nn kernel.
for #13634
ONE-DCO-1.0-Signed-off-by: Artem Balyshev a.balyshev@samsung.com