[onert-micro] Reduce duplicate code in pool layers #12428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ragmani
force-pushed
the
onert-micro/Reduce_DC_pool_layers
branch
from
2b48924
to
0c74805
Compare
ragmani
added
PR/NO MERGE
This commit reduces duplicate code in pool layers.
- Introduce Pool2DCommon.h that has common functions for pool layers.
- configure_kernel_CirclePool2DCommon : unifies configure function of pool layers.
- createPoolParams : unifies creating parameters of pool layers.
- Apply common function for pool layers.
ONE-DCO-1.0-Signed-off-by: ragmani <ragmani0216@gmail.com>
ragmani
force-pushed
the
onert-micro/Reduce_DC_pool_layers
branch
from
0c74805
to
63d9907
Compare
Comment on lines
56
to
57
| inline luci_interpreter_pal::PoolParams createPoolParams(const circle::Operator *cur_op, | ||
| BaseRuntimeGraph *runtime_graph) |
There was a problem hiding this comment.
I think it's better to pass const kernels::SISOKernel &siso_kernel parameter here so as not to read the input and output tensor twice, since this has already been done in the calling function.
What do you think?)
There was a problem hiding this comment.
Do you mean to pass const kernels::SISOKernel &siso_kernel instead of BaseRuntimeGraph *runtime_graph? I think it looks better.
Comment on lines
59
to
63
| const auto input_index = cur_op->inputs()->operator[](0); | ||
| const auto output_index = cur_op->outputs()->operator[](0); | ||
|
|
||
| assert(input_index != -1); | ||
| assert(output_index != -1); |
There was a problem hiding this comment.
so, now input_index and output_index can be removed, I think
ragmani
force-pushed
the
onert-micro/Reduce_DC_pool_layers
branch
from
90562d3
to
8b45469
Compare
|
@chunseoklee, PTAL) |
chunseoklee
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit reduces duplicate code in pool layers.
ONE-DCO-1.0-Signed-off-by: ragmani ragmani0216@gmail.com
For #11744