Drop deprecated proc-macro-hack #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop deprecated proc-macro-hack Update libflate to 2.0
SOF3
reviewed
Oct 14, 2023
SOF3
approved these changes
Oct 14, 2023
SOF3
reviewed
Oct 14, 2023
| pub use include_flate_codegen::deflate_file; | ||
|
|
||
| #[cfg_attr(feature = "stable", proc_macro_hack::proc_macro_hack)] | ||
| pub use include_flate_codegen::deflate_utf8_file; |
There was a problem hiding this comment.
Could we just as well delete this reexport crate directly?
There was a problem hiding this comment.
Honestly, I'm not sure but I would guess so. Would just have to try it.
(The original comment was made too quickly, I didn't read it and thought this was about something else)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes do up the actual MSRV to at least Rust 1.45, but that was released 3 years ago on
July 16, 2020so it shouldn't be an issue. I did a version bump anyway due to the MSRV bump and the updated 2021 edition is more constricting anyway.From the
proc-macro-hackcrate:Dropping this crate and using the std
#[proc_macro]lets it build on stable Rust by default, without flags. Thestablefeature is still included due to the flags in the test modules, but has no actual impact on the code - I'm not sure what to do about it, but you can remove thestablefeature and everything works if you delete the requirement of the nightly only feature in the tests.proc-macro-hack2021(not required to compile on stable, could revert)libflateto 2.0 (not required to compile on stable, could revert)0.3.0due to MSRV bump