add no_std support #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SOF3
requested changes
Sep 27, 2023
| stable = ["include-flate-codegen-exports/stable"] | ||
| std = ["include-flate-codegen-exports/std", "libflate/std", "core2/std"] |
There was a problem hiding this comment.
Please preserve the trailing newlines
| @@ -26,6 +26,10 @@ | |||
| //! which might be undesirable if the data are too large. | |||
| //! An actual installer is still required if the binary involves too many resources that do not need to be kept in RAM all time. | |||
|
|
|||
| #![cfg_attr(not(any(test, feature = "std")), no_std)] | |||
There was a problem hiding this comment.
Do we really need a feature gate for this? #![no_std] should be usable in binaries compiled with std as well.
| pub type String = ::std::string::String; | ||
|
|
||
| #[cfg(not(feature = "std"))] | ||
| pub type String = ::alloc::string::String; |
There was a problem hiding this comment.
::std::string::String is an alias of ::alloc::string::String, why do we need to differentiate them?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19