Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom resolution size added for start modes main and game #1622

Closed
wants to merge 1 commit into from

Conversation

jTorresR8
Copy link

partial solution for the problem:
#1546

implemented cli arguments for window screen width and height parameters for the main and game start modes for the openage game engine.

@jTorresR8 jTorresR8 closed this Feb 12, 2024
@heinezen
Copy link
Member

Hey thank you but why did you close this?

@jTorresR8
Copy link
Author

if I'm honest, I got scared/discouraged when I saw a bunch of automated tests fail due to my misconfiguration of the project probably. (I never got to display anything besides the diamond with orange background)

although I did get the cli parameters for custom screen width/height working , I couldn't find a way to implement vsync or find out the resolution of the target display to then pass it as parameters.

@heinezen
Copy link
Member

@torresja2911 The CI checks are there to help you see what's wrong and not to discourage you :)

If you don't understand some of them, you can always ask in the chat or in the issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants