Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI parameters for window settings #1546

Open
3 tasks
heinezen opened this issue Sep 17, 2023 · 4 comments · May be fixed by #1672
Open
3 tasks

CLI parameters for window settings #1546

heinezen opened this issue Sep 17, 2023 · 4 comments · May be fixed by #1672
Assignees
@RaulGalvez288
Labels
area: renderer Concerns our graphics renderer good first issue Suitable for newcomers lang: c++ Done in C++ code lang: cython Implemented using Cython code lang: python Done in Python code nice new thing ☺ A new feature that was not there before

Comments

@heinezen
Copy link
Member

Required Skills: Python, some C++

Difficulty: Easy

Several window parameters could be set via the CLI on startup. Examples for these parameters include:

  • window size (height x width)
  • vsync
  • fullscreen/borderless/windowed

Most of the parameters are already supported by the renderer::Window class. All we have to do is pass them through from the Python CLI.

Tasks:

  • Start parameters have to be defined in Python for start modes main and game
  • Pass parameters to C++ invocation main_arguments struct
  • in C++, pass relevant parameters to presenter/renderer subsystem

Further Reading
@heinezen heinezen added area: renderer Concerns our graphics renderer nice new thing ☺ A new feature that was not there before lang: c++ Done in C++ code lang: python Done in Python code lang: cython Implemented using Cython code good first issue Suitable for newcomers labels Sep 17, 2023
@heinezen heinezen pinned this issue Sep 17, 2023
@heinezen heinezen added the hacktoberfest For newcomers from Hacktoberfest event label Sep 27, 2023
@stoyanov-kaloyan
Copy link

Hi! I would like to work on this issue. Can you please assign it to me?

@heinezen
Copy link
Member Author

heinezen commented Oct 2, 2023

@stoyanov-kaloyan Great :) I've assigned you just now.

@Aayush-lad Aayush-lad mentioned this issue Oct 3, 2023
Closed
@heinezen heinezen removed the hacktoberfest For newcomers from Hacktoberfest event label Nov 4, 2023
@jTorresR8 jTorresR8 mentioned this issue Feb 12, 2024
Closed
@RaulGalvez288
Copy link

Hi, I want to contribute to this project and I figured this issue would be a great place to start. Can I be assigned to it?

@TheJJ
Copy link
Member

TheJJ commented Aug 20, 2024

done - but generally this is not needed to work on something :) usually, just submit the pull request

@RaulGalvez288 RaulGalvez288 linked a pull request Aug 20, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RaulGalvez288 RaulGalvez288

Labels
area: renderer Concerns our graphics renderer good first issue Suitable for newcomers lang: c++ Done in C++ code lang: cython Implemented using Cython code lang: python Done in Python code nice new thing ☺ A new feature that was not there before
Projects
openage beginner tasks
Status: renderer
openage renderer
Status: 🔖 TODO
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added custom resolution size for main and game RaulGalvez288/openage
4 participants
@TheJJ @heinezen @stoyanov-kaloyan @RaulGalvez288