Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial import #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Initial import #1

wants to merge 2 commits into from

Conversation

werdahias
Copy link

Should work, I fixed the lintian warnongs as best as I could. The package still needs an ITP bug report on wnpp.debian.net Feel free to publish it as long as you credit me. Also. the description could need some work.

Copy link
Member

@TheJJ TheJJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for your work!

what does it mean for nyan to be on salsa? it has to live there for some time in order to get packaged in debian afterwards I guess?

2016-2022 Michael Enßlin <michael@ensslin.cc>
2016-2022 Andre Kupka <kupka@in.tum.de>
2016-2022 Tushar Maheshwari <tushar27192@gmail.com>
2016-2022 Andrew Thompson <mrwerdo331@me.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think as we have so many authors, a link to the author document would be better here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Afaik you have to include all the authors even if there are a lot.

Copy link
Member

@TheJJ TheJJ Apr 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, but then the list would be really long, and would outdate very quickly.
Can't we do Copyright: 2013-2022 the nyan authors like we do in all source files?

debian/copyright Outdated
@@ -0,0 +1,43 @@
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: font-downloader
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems incorrect

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, missed that.

Section: libs
Homepage: https://github.com/SFTtech/nyan
#Vcs-Browser: https://salsa.debian.org/debian/nyan
#Vcs-Git: https://salsa.debian.org/debian/nyan.git
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we also want to list the github-remote here, or just salsa? i don't know the conventions

@werdahias
Copy link
Author

thank you for your work!

what does it mean for nyan to be on salsa? it has to live there for some time in order to get packaged in debian afterwards I guess?

Yeah. If it is to get in the official repos it would need to be uploaded there.



%:
dh $@
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this invoke autotools? Because nyan should be built and packaged with cmake?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants