-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OFA] ビューのサマリを表示する #157
[OFA] ビューのサマリを表示する #157
Conversation
{ name: "Group F", value: 189 }, | ||
]; | ||
export const ShowChartServer = async ({ appId }: { appId: string }) => { | ||
// レコードデータの呼び出しは RecordListServer を参照 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ここのコメントはもう不要になったので削除でー
records: Records; | ||
criteria: SummaryCriteria; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
対応不要な備忘録
複数の引数がある時
a: string, b: stringだと
引数を渡す時に、間違えることがあるので、オブジェクトに包むようにしています
今回の場合は、それぞれ型がしっかりとあるので
オブジェクトで包むのは必須ではないです
it("", () => { | ||
const criteria: SummaryCriteria = { | ||
groupingFields: { | ||
"1718289203212": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
describe("sumRecords", () => { | ||
it("", () => { | ||
const records: Records = { | ||
r1: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
上記の指摘
この辺参考になりそう
- Implementation of sumRecords.ts.
- separated functions.
- Delete unnecessary comments.
- Implementing a unit test for createDateArray.
- Fix createDateArray.
- Correcting test data and handling errors.
No description provided.