[OFA] ビューのサマリを表示する #157
Merged
[OFA] ビューのサマリを表示する #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ryo-Kgym
commented
Jun 24, 2024
| { name: "Group F", value: 189 }, | ||
| ]; | ||
| export const ShowChartServer = async ({ appId }: { appId: string }) => { | ||
| // レコードデータの呼び出しは RecordListServer を参照 |
Comment on lines
+9
to
+10
| records: Records; | ||
| criteria: SummaryCriteria; |
There was a problem hiding this comment.
対応不要な備忘録
複数の引数がある時
a: string, b: stringだと
引数を渡す時に、間違えることがあるので、オブジェクトに包むようにしています
今回の場合は、それぞれ型がしっかりとあるので
オブジェクトで包むのは必須ではないです
Ryo-Kgym
commented
Jul 1, 2024
| it("", () => { | ||
| const criteria: SummaryCriteria = { | ||
| groupingFields: { | ||
| "1718289203212": { |
There was a problem hiding this comment.
テストデータで使用する値は、実データと遠いものかつそれ自体がわかりやすいものがいいですね。
ここで重要なのは、文字・数字が他のどの部分で使用されているかがパッとわかることです
そうすることで、単体テストの可読性が一気に上がります。
他にサンプルがいくつもあるので真似てみてください
| describe("sumRecords", () => { | ||
| it("", () => { | ||
| const records: Records = { | ||
| r1: { |
- Implementation of sumRecords.ts.
- separated functions.
- Delete unnecessary comments.
- Implementing a unit test for createDateArray.
- Fix createDateArray.
- Correcting test data and handling errors.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.