ci: move lint out of build #1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
alexandre-abrioux,
KolevDarko,
olivier7delf and
yomarion
benjlevesque
commented
Nov 17, 2023
Comment on lines
+99
to
+100
| paths: | ||
| - ./ |
There was a problem hiding this comment.
just remove a warning from the json schema
benjlevesque
commented
Nov 17, 2023
| lint-package-json: | ||
| paths: | ||
| - ./ | ||
| lint: |
There was a problem hiding this comment.
rename job to match what it does
benjlevesque
commented
Nov 17, 2023
Comment on lines
+108
to
+113
| - run: | ||
| name: Verify format | ||
| command: yarn format:check | ||
| - run: | ||
| name: Verify lint | ||
| command: yarn lint:check |
benjlevesque
commented
Nov 17, 2023
| @@ -659,44 +660,48 @@ workflows: | |||
| # Publish the code coverage | |||
| - publish-coverage: | |||
| requires: | |||
| - test-request-client | |||
| - lint | |||
There was a problem hiding this comment.
add lint, integration-test and smart-contracts which were missing
sort all tests
benjlevesque
commented
Nov 17, 2023
Comment on lines
-717
to
-719
| - lint-package-json: | ||
| requires: | ||
| - build |
There was a problem hiding this comment.
unnecessary in nighly build
MantisClone
approved these changes
Nov 17, 2023
KolevDarko
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the format & lint takes about a minute. It shouldn't be part of the
buildstage, but in a separatelintstage (together with package.json lint)