refactor: currency types #1238
Merged
refactor: currency types #1238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjlevesque
commented
Nov 14, 2023
packages/advanced-logic/src/extensions/payment-network/near/any-to-near-testnet.ts
Outdated
Show resolved
Hide resolved
benjlevesque
commented
Nov 14, 2023
benjlevesque
commented
Nov 14, 2023
benjlevesque
commented
Nov 14, 2023
| @@ -41,8 +41,7 @@ export default class HttpRequestNetwork extends RequestNetwork { | |||
| nodeConnectionConfig?: Partial<NodeConnectionConfig>; | |||
| signatureProvider?: SignatureProviderTypes.ISignatureProvider; | |||
| useMockStorage?: boolean; | |||
| currencies?: CurrencyInput[]; | |||
There was a problem hiding this comment.
Breaking: I suggest to remove this parameter as it's redundant with currencyManager
There was a problem hiding this comment.
Agreed it's redundant, but is the currencyManager the better choice? I'm not super familiar.
There was a problem hiding this comment.
between the two? I would say yes: it enables injecting your own implementation, and the CurrencyManager contains more than just a list of currencies. For instance, it contains the list of Aggregators for conversion
There was a problem hiding this comment.
Okay. 👍 Thanks for explaining
benjlevesque
force-pushed
the
refactor/remove-axios
branch
from
c33e957
to
0def2ba
Compare
benjlevesque
force-pushed
the
refactor/remove-axios
branch
2 times, most recently
from
d68636a
to
8e03773
Compare
Apply suggestions from code review
benjlevesque
force-pushed
the
refactor/currency-types
branch
from
060bdc0
to
c165aba
Compare
github-actions
bot
requested review from
alexandre-abrioux,
leoslr,
MantisClone and
yomarion
alexandre-abrioux
approved these changes
Apr 23, 2024
leoslr
approved these changes
May 3, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move all types to the
typespackage for better consistency with other types and as a first step to reduce unnecessary dependencies to the currency package.BREAKING: types must be updated with
CurrencyTypesprefix, imported from@requestnetwork/typespackage.BREAKING: the
currenciesfield has been removed from theRequestNetworkclient parameters. UsecurrencyManager: new CurrencyManager(CURRENCIES)instead.