-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add support for node v18 #1173
Conversation
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
07a7412
to
bac9c3c
Compare
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
…)" This reverts commit 50479af.
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing! I tested the yarn run build
with Node 16.18.1 and Node 18.12.1 and it worked in both cases.
I created #1178 as a follow-up to make sure that both node v16 and v18 are included in our CircleCI tests.
I don't understand why the CircleCI checks aren't starting. @benjlevesque Any idea why this is happening? |
@MantisClone @OjusWiZard I don't see the error in the CircleCI dashboard, and we got a successful build a few hours ago, maybe a temporary issue on CircleCI? Can you retry? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Description of the changes
Fixes #1009
To add support for node v18:
webpack
to latest v5 in epk-decryption, epk-signature, request-client.js, and web3-signature packagescrypto-browserify
andstream-browserify
to handle the breaking changes in webpackThere are some warnings introduced now.
Tested using node v18.17.1 and v18.18.0