chore: add support for node v18 #1173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OjusWiZard
changed the title
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
OjusWiZard
force-pushed
the
fix/#1009
branch
from
07a7412
to
bac9c3c
Compare
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
…)" This reverts commit 50479af.
OjusWiZard
changed the title
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
github-actions
bot
requested review from
benjlevesque,
leoslr,
olivier7delf and
yomarion
MantisClone
approved these changes
Sep 27, 2023
There was a problem hiding this comment.
Thanks for contributing! I tested the yarn run build with Node 16.18.1 and Node 18.12.1 and it worked in both cases.
I created #1178 as a follow-up to make sure that both node v16 and v18 are included in our CircleCI tests.
|
I don't understand why the CircleCI checks aren't starting. @benjlevesque Any idea why this is happening? |
|
Not sure about the root cause, but the circleci dashboard shows this. |
|
@MantisClone @OjusWiZard I don't see the error in the CircleCI dashboard, and we got a successful build a few hours ago, maybe a temporary issue on CircleCI? Can you retry? |
|
I logged into CircleCI and was able to trigger the CI by clicking "Trigger Pipeline" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
Fixes #1009
To add support for node v18:
webpackto latest v5 in epk-decryption, epk-signature, request-client.js, and web3-signature packagescrypto-browserifyandstream-browserifyto handle the breaking changes in webpackThere are some warnings introduced now.
Tested using node v18.17.1 and v18.18.0