fix: remove hardcoded chainlink rate age (#1171) #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
github-actions
bot
requested review from
leoslr,
MantisClone,
olivier7delf and
yomarion
yomarion
reviewed
Sep 19, 2023
That makes sense. Thanks for the review! |
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
MantisClone
approved these changes
Sep 21, 2023
OjusWiZard
added a commit
to OjusWiZard/requestNetwork
that referenced
this pull request
Sep 21, 2023
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1144
Hi, a new contributor here!
Trying to fix the issue #1144
Description of the changes
I've added an optional parameter
maxRateAgeinISwapSettingsIConversionSettings. It defaults to 0.We can keep it required too, wdyt?