-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: deploy on mantle and mantle testnet #1127
Conversation
…uestNetwork into deploy-mantle-testnet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you mean to version this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I don't think this file needs to be versioned. We edit the create2ContractDeploymentList
based on which contracts we're trying to deploy.
If you're asking about "create2" in the filename, that's referring to the CREATE2 opcode which is one of the key ingredients to the xdeployer which makes our smart contract addresses the same across multiple chains.
try { | ||
const RequestDeployer = await hre.ethers.getContractAt( | ||
'RequestDeployer', | ||
'0xE99Ab70a5FAE59551544FA326fA048f7B95A24B2', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this address?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the address of the RequestDeployer
contract, same on all networks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should be a variable or should have a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is one in the hardhat config file actually. Maybe we should put it elsewhere and export it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. Okay I'll fix this.
Description of the changes
Deploy the following contracts on Mantle
Deploy the following contracts on Mantle Testnet
Update
hardhat-etherscan
to latest version 3.1.7Add function for verifying RequestDeployer