Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fungible proxy #12

Merged
merged 14 commits into from
Apr 12, 2023
Merged

feat: fungible proxy #12

merged 14 commits into from
Apr 12, 2023

Conversation

yomarion
Copy link
Member

@yomarion yomarion commented Mar 16, 2023

Smart contract to handle fungible token transfers with no conversion.

Copy link
Member

@MantisClone MantisClone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @yomarion.

  1. Please add the new fungible_proxy tests to the GitHub Action.
  2. The fungible_proxy tests are failing with the following error:
    mantisclone@mantisclone-Inspiron-7620:~/projects/near-contracts/fungible_proxy$ ./test.sh 
           Compiling fungible_proxy v0.0.1 (/home/mantisclone/projects/near-contracts/fungible_proxy)
    error[E0560]: struct `PaymentArgs` has no field named `amount`
       --> fungible_proxy/src/lib.rs:240:13
        |
    240 |             amount: 1000000.into(),
        |             ^^^^^^ `PaymentArgs` does not have this field
        |
        = note: available fields are: `fee_address`, `fee_amount`, `payment_reference`, `to`
    
    For more information about this error, try `rustc --explain E0560`.
    error: could not compile `fungible_proxy` due to previous error
    
  3. The top-level test.sh fails with the following error:
    error: linking with `cc` failed: exit status: 1
    ...snip for brevity...
      = note: /usr/bin/ld: cannot find -lstdc++: No such file or directory
              collect2: error: ld returned 1 exit status
              
    
    error: could not compile `request_conversion_proxy` due to previous error
    

@yomarion
Copy link
Member Author

yomarion commented Apr 4, 2023

Hey @yomarion.

  1. Please add the new fungible_proxy tests to the GitHub Action.
  2. The fungible_proxy tests are failing with the following error:
    mantisclone@mantisclone-Inspiron-7620:~/projects/near-contracts/fungible_proxy$ ./test.sh 
           Compiling fungible_proxy v0.0.1 (/home/mantisclone/projects/near-contracts/fungible_proxy)
    error[E0560]: struct `PaymentArgs` has no field named `amount`
       --> fungible_proxy/src/lib.rs:240:13
        |
    240 |             amount: 1000000.into(),
        |             ^^^^^^ `PaymentArgs` does not have this field
        |
        = note: available fields are: `fee_address`, `fee_amount`, `payment_reference`, `to`
    
    For more information about this error, try `rustc --explain E0560`.
    error: could not compile `fungible_proxy` due to previous error
    
  3. The top-level test.sh fails with the following error:
    error: linking with `cc` failed: exit status: 1
    ...snip for brevity...
      = note: /usr/bin/ld: cannot find -lstdc++: No such file or directory
              collect2: error: ld returned 1 exit status
              
    
    error: could not compile `request_conversion_proxy` due to previous error
    

Thanks @MantisClone , I've fixed points 1. and 2.

About point n.3 maybe a missing dependency on your local environment? Don't you have the same problem on master? The test.sh script does not do much and both build and tests work in GH workflows

@yomarion yomarion enabled auto-merge (squash) April 4, 2023 17:41
Copy link
Member

@MantisClone MantisClone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great looking PR!

deploy.sh Outdated Show resolved Hide resolved
deploy.sh Outdated Show resolved Hide resolved
deploy.sh Outdated Show resolved Hide resolved
fungible_proxy/src/lib.rs Outdated Show resolved Hide resolved
fungible_proxy/src/lib.rs Outdated Show resolved Hide resolved
tests/sim/utils.rs Outdated Show resolved Hide resolved
tests/sim/utils.rs Outdated Show resolved Hide resolved
fungible_proxy/src/lib.rs Outdated Show resolved Hide resolved
tests/sim/fungible_proxy.rs Show resolved Hide resolved
tests/sim/fungible_proxy.rs Show resolved Hide resolved
fungible_proxy/src/lib.rs Outdated Show resolved Hide resolved
fungible_proxy/Cargo.toml Show resolved Hide resolved
tests/sim/fungible_proxy.rs Show resolved Hide resolved
tests/sim/fungible_proxy.rs Show resolved Hide resolved
@yomarion yomarion merged commit 8b499be into main Apr 12, 2023
@yomarion yomarion deleted the feat/fungible_proxy branch April 12, 2023 11:57
@yomarion yomarion mentioned this pull request Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants