-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry-picks for the master (4.4) branch - 2nd batch #804
Open
Spartan322
wants to merge
17
commits into
Redot-Engine:master
Choose a base branch
from
Spartan322:cherry-pick/4.3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spartan322
added
cherrypick:master
Considered for cherry-picking into a master
bug
topic:gui
enhancement
labels
Oct 25, 2024
SkogiB
approved these changes
Oct 26, 2024
Spartan322
added
rebranding
issues and pr's related to engine rebranding
platform:linuxbsd
topic:editor
topic:2d
labels
Oct 26, 2024
RadenTheFolf
approved these changes
Oct 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure why some of the changes are just switching if statements from if condition {} else {} to the conditional op ? . guess it does look cleaner
Spartan322
force-pushed
the
cherry-pick/4.3
branch
from
October 30, 2024 10:21
961e416
to
2b5c37e
Compare
SkogiB
approved these changes
Oct 30, 2024
Spartan322
removed
the
cherrypick:master
Considered for cherry-picking into a master
label
Oct 31, 2024
Remove vbl child from `ColorPicker` Remove vbr child from `ColorPicker`, prefer `real_vbox` (cherry picked from commit blazium-engine/blazium@f7c6762) (cherry picked from commit 18d0193) Co-authored-by: Mounir Tohami <53877170+WhalesState@users.noreply.github.com>
(cherry picked from commit blazium-engine/blazium@f7c6762) (cherry picked from commit 9db102a) Co-authored-by: Mounir Tohami <53877170+WhalesState@users.noreply.github.com>
It seems to be vestigial inherited from the ColorPicker refactor (cherry picked from commit blazium-engine/blazium@f7c6762) (cherry picked from commit 86eb475) Co-authored-by: Mounir Tohami <53877170+WhalesState@users.noreply.github.com>
(cherry picked from commit blazium-engine/blazium@f7c6762) (cherry picked from commit e3650df) Co-authored-by: Mounir Tohami <53877170+WhalesState@users.noreply.github.com>
(cherry picked from commit blazium-engine/blazium@f7c6762) (cherry picked from commit 59101cb) Co-authored-by: Mounir Tohami <53877170+WhalesState@users.noreply.github.com>
(cherry picked from commit blazium-engine/blazium@f7c6762) (cherry picked from commit e3ac6fb) Co-authored-by: Mounir Tohami <53877170+WhalesState@users.noreply.github.com>
(cherry picked from commit blazium-engine/blazium@f7c6762) (cherry picked from commit 3265e08) Co-authored-by: Mounir Tohami <53877170+WhalesState@users.noreply.github.com>
(cherry picked from commit blazium-engine/blazium@f7c6762) (cherry picked from commit 7a16a43) Co-authored-by: Mounir Tohami <53877170+WhalesState@users.noreply.github.com>
…ight. (cherry picked from commit blazium-engine/blazium@f7c6762) (cherry picked from commit 72ade00) Co-authored-by: Mounir Tohami <53877170+WhalesState@users.noreply.github.com>
(cherry picked from commit blazium-engine/blazium@ca09c1d) (cherry picked from commit ad35df2) Co-authored-by: Mounir Tohami <53877170+WhalesState@users.noreply.github.com>
(cherry picked from commit blazium-engine/blazium@a501d9f) (cherry picked from commit 8880ef6) Co-authored-by: Mounir Tohami <53877170+WhalesState@users.noreply.github.com>
(cherry picked from commit blazium-engine/blazium@5ca9caa) (cherry picked from commit d09a29e) Co-authored-by: Mounir Tohami <53877170+WhalesState@users.noreply.github.com>
(cherry picked from commit blazium-engine/blazium@5ca9caa) (cherry picked from commit 40d36f6) Co-authored-by: Mounir Tohami <53877170+WhalesState@users.noreply.github.com>
(cherry picked from commit blazium-engine/blazium@5ca9caa) (cherry picked from commit f6edeb0) Co-authored-by: Mounir Tohami <53877170+WhalesState@users.noreply.github.com>
(cherry picked from commit 78ae5ca)
Spartan322
force-pushed
the
cherry-pick/4.3
branch
from
October 31, 2024 06:22
61ef20f
to
4b57cdf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
enhancement
platform:linuxbsd
rebranding
issues and pr's related to engine rebranding
topic:editor
topic:gui
topic:network
topic:2d
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
ColorPicker
's sample left half side changes the color to black when old color is not displayed. godotengine/godot#88073Includes:
EditorSpinSlider
grabber doesn't follow parent when scrolling #776ScrollBar
grabber mouse ignores scroll margin #777ColorPicker
RGB+RAW modes to have overbright values #778ColorPicker
Containers #779ColorPicker
HSV Rectangle/Wheel draw #781ColorModeOKHSL.get_shape_override
#782ColorPicker
color mode slider colors #783ColorPicker
color picking #784ColorMode
jank sliders and spinbox #794ColorPicker
inactive left side sample reset #795ColorPicker
overbright indicator position #803CanvasItemEditor
redraw on key echo #805CanvasItemEditor
duplicate hovering behavior #806CanvasItemEditor
snap lines drawing and input #807