Fixes integration with wslay to prevent accepting packets when in_buffer full #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaidyQK
suggested changes
Oct 8, 2024
|
looks good |
|
This issue probably should be targeting the master branch, the commits should be squashed into a single commit, the commit message and PR title should be descriptive of what this is fixing, (preferably kept short yet descriptive) and the description should say |
RadenTheFolf
changed the title
|
Closing in preference to #697. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a fix to #31
Allows wslay to reject packets when in_buffer is nearly full. Doing so restores TCP's behavior to handle dropping and retransmission of packets instead of accepting all packets and dropping them in the application layer.
Issue stemmed from the implementation around Wslay not interrupting the reciving of packets when the in_buffer was nearly full leading to the loss of data.