Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes integration with wslay to prevent accepting packets when in_buffer full #262

Conversation

RadenTheFolf
Copy link
Contributor

@RadenTheFolf RadenTheFolf commented Oct 8, 2024

Added a fix to #31

Allows wslay to reject packets when in_buffer is nearly full. Doing so restores TCP's behavior to handle dropping and retransmission of packets instead of accepting all packets and dropping them in the application layer.

Issue stemmed from the implementation around Wslay not interrupting the reciving of packets when the in_buffer was nearly full leading to the loss of data.

Copy link

@RaidyQK RaidyQK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Convert the 1 liners to 1 line logic, no need for extra brackets

modules/websocket/packet_buffer.h Outdated Show resolved Hide resolved
@wesamdev
Copy link
Contributor

wesamdev commented Oct 8, 2024

looks good

@Spartan322
Copy link
Member

Spartan322 commented Oct 9, 2024

This issue probably should be targeting the master branch, the commits should be squashed into a single commit, the commit message and PR title should be descriptive of what this is fixing, (preferably kept short yet descriptive) and the description should say Fixes #31. Please see Godot's PR Workflow Docs and Godot's PR review guidelines Docs

@RadenTheFolf RadenTheFolf changed the title fix bug defined in issue #31 Fixes #31 Oct 10, 2024
@RadenTheFolf RadenTheFolf changed the title Fixes #31 Fixes TCP bug defined in issue 31 Oct 10, 2024
@RadenTheFolf RadenTheFolf changed the title Fixes TCP bug defined in issue 31 Fixes integration with wslay to prevent accepting packets when in_buffer full Oct 11, 2024
@Spartan322
Copy link
Member

Closing in preference to #697.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants