[WIP] Makefile changes #120
Conversation
|
SonarCloud Quality Gate failed.
|
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
| @@ -30,7 +30,7 @@ type Game struct { | |||
| Categories []string `json:"categories"` | |||
| } | |||
|
|
|||
| func init() { | |||
| func _init() { | |||
There was a problem hiding this comment.
U1000: func _init is unused
(at-me in a reply with help or ignore)
| @@ -30,7 +30,7 @@ type Game struct { | |||
| Categories []string `json:"categories"` | |||
| } | |||
|
|
|||
| func init() { | |||
| func _init() { | |||
There was a problem hiding this comment.
deadcode: _init is unused
(at-me in a reply with help or ignore)
Codecov Report
@@ Coverage Diff @@
## master #120 +/- ##
==========================================
- Coverage 76.90% 76.72% -0.19%
==========================================
Files 13 13
Lines 1104 1104
==========================================
- Hits 849 847 -2
- Misses 198 199 +1
- Partials 57 58 +1
Continue to review full report at Codecov.
|
|
|
||
| fmt: | ||
| $(GOFMT) ./... | ||
|
|
||
| godoc_examples: get fmt | ||
| $(GOTEST) -race -covermode=atomic ./redisearch | ||
|
|
||
| TEST ?= Test | ||
| ifeq ($(VERBOSE),1) | ||
| TEST_FLAGS += -v |
There was a problem hiding this comment.
we should add -count=1 to TEST_FLAGS to ensure multiple calls to test do indeed trigger the tests.
| @@ -60,3 +78,11 @@ godoc: | |||
| echo "Open browser tab on localhost:6060" | |||
| $(GODOC) | |||
|
|
|||
There was a problem hiding this comment.
if possible can we take this chance to also add the microbenchamrks rule @rafie ?
sample one:
https://github.com/HdrHistogram/hdrhistogram-go/blob/master/Makefile#L40
No description provided.