Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: don't use name-prefix when creating the drenv env #1603

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions docs/devel-quick-start.md
Original file line number Diff line number Diff line change
Expand Up @@ -107,20 +107,18 @@ You can either deploy the *Ramen* operator using the make targets or use the
- Using `ramenctl`

Ensure python virtual environment is active as `ramenctl` is a python tool.
The default name-prefix in the make target `create-rdr-env` is `rdr-`, we
will use the same in the `ramenctl` commands.

- Deploy the *Ramen* operator in the environment using `ramenctl`.

```sh
ramenctl deploy --name-prefix rdr- test/envs/regional-dr.yaml
ramenctl deploy test/envs/regional-dr.yaml
```

- Ramen needs to be configured to know about the managed clusters and the s3
endpoints. Configure the ramen operator for environment.

```sh
ramenctl config --name-prefix rdr- test/envs/regional-dr.yaml
ramenctl config test/envs/regional-dr.yaml
```

## Testing Ramen
Expand All @@ -133,6 +131,6 @@ If you want to clean up your environment, you can unconfigure *Ramen* and
undeploy it.

```sh
ramenctl unconfig --name-prefix rdr- test/envs/regional-dr.yaml
ramenctl undeploy --name-prefix rdr- test/envs/regional-dr.yaml
ramenctl unconfig test/envs/regional-dr.yaml
ramenctl undeploy test/envs/regional-dr.yaml
```
5 changes: 2 additions & 3 deletions hack/dev-env.sh
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
#!/bin/bash
set -e

RDR_NAME_PREFIX=${RDR_NAME_PREFIX:-rdr}
script_dir="$(cd "$(dirname "$0")" && pwd)"

if [[ $1 != "create" && $1 != "destroy" ]]; then
Expand All @@ -20,9 +19,9 @@ cd "$script_dir"/..
cd test

if [[ $1 == "create" ]]; then
drenv start --name-prefix "${RDR_NAME_PREFIX}"- envs/regional-dr.yaml
drenv start envs/regional-dr.yaml
fi

if [[ $1 == "destroy" ]]; then
drenv delete --name-prefix "${RDR_NAME_PREFIX}"- envs/regional-dr.yaml
drenv delete envs/regional-dr.yaml
fi