Cleanups in e2e retries #1599
Draft
Cleanups in e2e retries #1599
+26
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nirs
commented
Oct 22, 2024
•
nirs
commented
- Use time.Duration for timeouts
- Rename TimeoutInterval to RetryInterval
- Shorten retry internal to 5 seconds
- Remove unneeded use of fmt.Sprintf
We use untyped value with a // seconds comment, and then converted the untyped value to time.Duration everywhere. Use time.Duration to make the code more clear and less error prone. Signed-off-by: Nir Soffer <nsoffer@redhat.com>
The original name was not clear but we called it Retry Interval when logging the config. Signed-off-by: Nir Soffer <nsoffer@redhat.com>
5 seconds delay is large enough to avoid unwanted load on the environment, and short enough to detect changes quickly. With this change short operations that took more than 30 seconds before take now about 5 seconds. This also simplifies the retry loops to used special 5 seconds sleep before retrying. Now we check immediately since we will retry after 5 seconds anyway. Signed-off-by: Nir Soffer <nsoffer@redhat.com>
When using fmt.Errorf there is no need to format the error message. Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs
requested review from
raghavendra-talur,
rakeshgm,
ShyamsundarR and
BenamarMk
|
Needs rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.