Simplify test context management #1598
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had 2 places using a test context - test suites, and action helpers. To work with both, we store the test context in a map and had complicated search mechanism to locate the context in both the parent and child sub-tests. This failed randomly since the map was not protected with a mutex. Simplify the design by implementing the actions (deploy, enable, ..) in the test context. With this we can create a test context instance and pass it to the code running a test flow, and we don't need to manage any global state. Fixes: RamenDR#1571 Signed-off-by: Nir Soffer <nsoffer@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had 2 places using a test context - test suites, and action helpers. To work with both, we store the test context in a map and had complicated search mechanism to locate the context in both the parent and child sub-tests. This failed randomly since the map was not protected with a mutex.
Simplify the design by implementing the actions (deploy, enable, ..) in the test context. With this we can create a test context instance and pass it to the code running a test flow, and we don't need to manage any global state.
Fixes: #1571