-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VRG: Add multi StorageClasses support by filtering PeerClasses #1487
Open
rakeshgm
wants to merge
11
commits into
RamenDR:main
Choose a base branch
from
rakeshgm:vrg-peerclass-spec
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+984
−290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rakeshgm
commented
Jul 18, 2024
- Filter PeerClasses in VRG based on sync and async, finalise the selection of replicationClass and snapshotClass from the list of peerClasses.
- wip: fix unit tests
rakeshgm
force-pushed
the
vrg-peerclass-spec
branch
2 times, most recently
from
July 22, 2024 13:20
9157b6a
to
94b9e4c
Compare
rakeshgm
force-pushed
the
vrg-peerclass-spec
branch
8 times, most recently
from
July 31, 2024 14:06
6c768fd
to
8a71d34
Compare
rakeshgm
force-pushed
the
vrg-peerclass-spec
branch
5 times, most recently
from
August 6, 2024 12:32
792e99a
to
6faa41a
Compare
rakeshgm
force-pushed
the
vrg-peerclass-spec
branch
6 times, most recently
from
August 9, 2024 05:28
c97a818
to
ac13d94
Compare
rakeshgm
force-pushed
the
vrg-peerclass-spec
branch
2 times, most recently
from
September 23, 2024 09:39
a654e19
to
2e75380
Compare
Signed-off-by: rakeshgm <rakeshgm@redhat.com>
Signed-off-by: rakeshgm <rakeshgm@redhat.com>
improve filtering replicationClass Signed-off-by: rakeshgm <rakeshgm@redhat.com>
add StorageClass Labels, ReplicationClass Lables and PeerClasses Signed-off-by: rakeshgm <rakeshgm@redhat.com>
add StorgeClass Label, VolumeSnapshotClass Labels and PeerClasses Signed-off-by: rakeshgm <rakeshgm@redhat.com>
Signed-off-by: rakeshgm <rakeshgm@redhat.com>
Signed-off-by: rakeshgm <rakeshgm@redhat.com>
adding tests with no peerClasses and no replicaitonID in VRC Signed-off-by: rakeshgm <rakeshgm@redhat.com>
skip filtering using sid with replicationClass if peerclass is not found Signed-off-by: rakeshgm <rakeshgm@redhat.com>
update generated VRG PeerClasses only when VRG from ManagedCluster is available. This is to avoid updating VRG with a conflicting replicationClass Signed-off-by: rakeshgm <rakeshgm@redhat.com>
Signed-off-by: rakeshgm <rakeshgm@redhat.com>
rakeshgm
force-pushed
the
vrg-peerclass-spec
branch
from
October 18, 2024 10:05
5965ea6
to
0e0accd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.