You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We modify the textcontext map form multiple tests running in parallel,
so we must synchronize access to the map.
FixesRamenDR#1571
Signed-off-by: Nir Soffer <nsoffer@redhat.com>
We had 2 places using a test context - test suites, and action helpers.
To work with both, we store the test context in a map and had
complicated search mechanism to locate the context in both the parent
and child sub-tests. This failed randomly since the map was not
protected with a mutex.
Simplify the design by implementing the actions (deploy, enable, ..) in
the test context. With this we can create a test context instance and
pass it to the code running a test flow, and we don't need to manage any
global state.
Fixes: RamenDR#1571
Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs
linked a pull request
Oct 22, 2024
that will
close
this issue
We had 2 places using a test context - test suites, and action helpers.
To work with both, we store the test context in a map and had
complicated search mechanism to locate the context in both the parent
and child sub-tests. This failed randomly since the map was not
protected with a mutex.
Simplify the design by implementing the actions (deploy, enable, ..) in
the test context. With this we can create a test context instance and
pass it to the code running a test flow, and we don't need to manage any
global state.
Fixes: RamenDR#1571
Signed-off-by: Nir Soffer <nsoffer@redhat.com>
Looks like a random failure - maybe we are missing locking on a map?
Build: https://github.com/RamenDR/ramen/actions/runs/10992671688/job/30522993349
The text was updated successfully, but these errors were encountered: