-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PPU LLVM: Fix optimization of branch string #14620
Draft
elad335
wants to merge
1
commit into
RPCS3:master
Choose a base branch
from
elad335:llvm-ppu
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elad335
added
CPU
Optimization
Optimizes existing code
LLVM
Related to LLVM instruction decoders
labels
Sep 5, 2023
elad335
force-pushed
the
llvm-ppu
branch
3 times, most recently
from
September 5, 2023 08:37
0e7efd4
to
6b53315
Compare
I forgot to mention that if you want to be benefited from you have to delete cache. |
The game closes when trying to compile PPU modules on a fresh cache. E PPU: LLVM: Verification failed for v6-kusa-Kh8ANdpJ7R8TYsfsPsw6ct-00001P-icelake-client.obj:
Instruction does not dominate all uses!
%58 = add i64 4336, %2
store i64 %58, ptr %51, align 8 |
good can not download why? |
Any further testing needed? |
Well it seems some problem occured? |
It's not caused by this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out the branch optimization in #14616 was not active, this enables it.