Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cost 2020 update #123

Merged
merged 13 commits into from
Feb 28, 2024
Merged

Cost 2020 update #123

merged 13 commits into from
Feb 28, 2024

Conversation

lisazeyen
Copy link
Collaborator

Closes # (if applicable).

Changes proposed in this Pull Request

Checklist

  • Code changes are sufficiently documented; i.e. new functions contain docstrings and further explanations may be given in doc.
  • Data source for new technologies is cleary stated.
  • Newly introduced dependencies are added to environment.yaml (if applicable).
  • A note for the release notes doc/release_notes.rst of the upcoming release is included.
  • I consent to the release of this PR's code under the GPLv3 license.

@lisazeyen
Copy link
Collaborator Author

lisazeyen commented Feb 20, 2024

@JulianGeis thanks looks mostly good. The only problem is that there are also technologies with currency year 2019, so this year needs to be correctly assigned for adjusting to the inflation. So you basically need to split the technologies from new_format here into something like cost_year_2020 and cost_year_2019 and adjust the currency year and inflation correctly here

Also one would need to double check where else the variable new_format is used and if the code still works as intended.

And can you double, e.g. 103 Hydrogen to Ammonia in the Notes I it says it is in 2015_Euro...

@lisazeyen
Copy link
Collaborator Author

@JulianGeis nice seems to work as intended. Changes below

investment_biogas CC
VOM_Fischer-Tropsch
VOM_BtL
VOM_BioSNG
investment_biogas
investment_BioSNG

VOM_direct firing gas
investment_direct air capture
investment_cement capture
investment_direct firing gas CC
investment_direct firing gas
VOM_biomass-to-methanol
VOM_biogas upgrading
VOM_biogas plus hydrogen
investment_biomass-to-methanol
investment_biogas upgrading
investment_biomass CHP capture
investment_biogas plus hydrogen

VOM_direct firing solid fuels CC
investment_direct firing solid fuels CC
investment_direct firing solid fuels
investment_gas boiler steam
investment_electric boiler steam
VOM_direct firing solid fuels
VOM_direct firing gas CC

VOM_gas boiler steam
VOM_electric boiler steam
VOM_solid biomass boiler steam CC
VOM_solid biomass boiler steam
investment_industrial heat pump medium temperature
VOM_industrial heat pump medium temperature
investment_solid biomass boiler steam CC
investment_solid biomass boiler steam
investment_industrial heat pump high temperature
VOM_industrial heat pump high temperature

@lisazeyen lisazeyen marked this pull request as ready for review February 28, 2024 14:58
@lisazeyen lisazeyen merged commit 68bde67 into master Feb 28, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants