fix load weighted prices

[lisazeyen]

Changes proposed in this Pull Request

Fix bug when calculating load weighted prices in the make_summary script

Checklist

• I tested my contribution locally and it works as intended.
• Code and workflow changes are sufficiently documented.
• Changed dependencies are added to envs/environment.yaml.
• Changes in configuration options are added in config/config.default.yaml.
• Changes in configuration options are documented in doc/configtables/*.csv.
• Sources of newly added data are documented in doc/data_sources.rst.
• A release note doc/release_notes.rst is added.

[lisazeyen]

@millingermarkus can you check if it is working with this branch?

[lisazeyen]

@p-glaum I am not dropping the prices if the load is zero at a bus.
price = price.reindex(columns=load.columns)
One could also reindex the other way around, but then the mariginal price would not be really load weighted, e.g. with
load.reindex(columns=price.columns, fill_value=1)

[p-glaum]

@p-glaum I am not dropping the prices if the load is zero at a bus. price = price.reindex(columns=load.columns) One could also reindex the other way around, but then the mariginal price would not be really load weighted, e.g. with load.reindex(columns=price.columns, fill_value=1)

okay, if the prices have a meaning for buses without flows going in or out, then we should definitely keep them and weight every timestep equally, i.e. with load.reindex(columns=price.columns, fill_value=1)
However, if they do not have a realistic interpretation, should we drop them?

[lisazeyen]

@p-glaum I am not dropping the prices if the load is zero at a bus. price = price.reindex(columns=load.columns) One could also reindex the other way around, but then the mariginal price would not be really load weighted, e.g. with load.reindex(columns=price.columns, fill_value=1)

okay, if the prices have a meaning for buses flows going in or out, then we should definitely keep them and weight every timestep equally, i.e. wit load.reindex(columns=price.columns, fill_value=1) However, if they do not have a realistic interpretation, should we drop them?

I think if it is load weighted and the load is zero we should drop them.

[fneum]

I think if it is load weighted and the load is zero we should drop them.

I think equal weight would be slightly better, but dropping also ok.

[github-actions]

Validator Report

I am the Validator. Download all artifacts here.
I'll be back and edit this comment for each new commit.

General

Plots comparison

Main branch	Feature branch

Files comparison

	Status	NRMSE	MAE (norm)
nodal_capacities.csv	⚠️ NaN mismatch
cfs.csv	⚠️ NaN mismatch
nodal_costs.csv	⚠️ NaN mismatch
nodal_supply_energy.csv	⚠️ NaN mismatch
nodal_cfs.csv	⚠️ NaN mismatch
weighted_prices.csv	⚠️ NaN mismatch
curtailment.csv	✅ Almost equal	0.000	0.14
price_statistics.csv	✅ Almost equal	0.008	0.14
capacities.csv	✅ Almost equal	0.000	0.04
market_values.csv	✅ Almost equal	0.001	0.08
costs.csv	✅ Almost equal	0.001	0.01
metrics.csv	✅ Almost equal	0.000	0.06
prices.csv	✅ Almost equal	0.000	0.16
supply_energy.csv	✅ Almost equal	0.000	0.03
supply.csv	✅ Almost equal	0.000	0.03
energy.csv	✅ Almost equal	0.000	0.02

NRMSE: Normalized (min-max) Root Mean Square Error
MAE (norm): Mean Absolute Error on normalized Data (min-max
Status Threshold: MAE (norm) > 0.05 and NRMSE > 2

Model Metrics

Benchmarks

Comparing fix-load-weighted-prices (35d1e1e) with master (0a18ddb).
Branch is 7 commits ahead and 0 commits behind.
Last updated on 2024-09-13 16:54:26 CEST.